Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments in LedgerHistory::fixIndex (Version: 1.10) #4572

Closed
ckeshava opened this issue Jun 13, 2023 · 2 comments
Closed

Update comments in LedgerHistory::fixIndex (Version: 1.10) #4572

ckeshava opened this issue Jun 13, 2023 · 2 comments

Comments

@ckeshava
Copy link
Collaborator

ckeshava commented Jun 13, 2023 •
edited by intelliot
Loading

Issue Description

The LedgerHistory::fixIndex function returns false if a repair is performed. This is reflected in its usage here and here

The existing comment appears to contradict the return value of the function.

Here is a commit to this effect.

Steps to Reproduce

This is an update to a comment in the codebase

@thejohnfreeman Does this look okay?
@thejohnfreeman
Copy link
Collaborator

Your commit link is broken. Can you open a PR?

ckeshava added a commit to ckeshava/rippled that referenced this issue Jun 14, 2023
@ckeshava
fix XRPLF#4572 : Update comment about return value of LedgerHistory::…
4ccca53 
…fixIndex
@ckeshava ckeshava mentioned this issue Jun 14, 2023
Merged
7 tasks
@intelliot
Copy link
Collaborator

(I edited ckeshava's post to fix the commit link.)

ckeshava added a commit to ckeshava/rippled that referenced this issue Sep 22, 2023
@ckeshava
docs: fix comment for LedgerHistory::fixIndex return value (XRPLF#4574)
4e75aab 
`LedgerHistory::fixIndex` returns `false` if a repair was performed.

Fix XRPLF#4572
ckeshava added a commit to ckeshava/rippled that referenced this issue Sep 25, 2023
@ckeshava
docs: fix comment for LedgerHistory::fixIndex return value (XRPLF#4574)
2995d94 
`LedgerHistory::fixIndex` returns `false` if a repair was performed.

Fix XRPLF#4572
sophiax851 pushed a commit to sophiax851/rippled that referenced this issue Jun 12, 2024
@ckeshava @sophiax851
docs: fix comment for LedgerHistory::fixIndex return value (XRPLF#4574)
0f453ce 
`LedgerHistory::fixIndex` returns `false` if a repair was performed.

Fix XRPLF#4572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@intelliot @thejohnfreeman @ckeshava