Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowClawback flag is missing from the account_info.account_flags response (Version: 1.12.0-beta1) #4588

Closed
ckniffen opened this issue Jun 26, 2023 · 1 comment
Closed

allowClawback flag is missing from the account_info.account_flags response (Version: 1.12.0-beta1) #4588

ckniffen opened this issue Jun 26, 2023 · 1 comment
Assignees
@shawnxie999

Comments

@ckniffen
Copy link
Collaborator

Issue Description

In rippled@1.11.0 a new object called account_flags was introduced to the account_info response. An entry needs to be added for lsfAllowClawback

This likely was missed because work was being done on both PRs at the same time.

https://github.com/drlongle/rippled/blob/develop/src/ripple/rpc/handlers/AccountInfo.cpp#L80-L100
@shawnxie999 shawnxie999 mentioned this issue Jun 27, 2023
Merged
7 tasks
@intelliot
Copy link
Collaborator

(Clawback implementation can be found here)

ckeshava pushed a commit to ckeshava/rippled that referenced this issue Jul 10, 2023
@shawnxie999 @ckeshava
fix: add allowClawback flag for account_info (XRPLF#4590)
a6664eb 
* Update the `account_info` API so that the `allowClawback` flag is
  included in the response.
  * The proposed `Clawback` amendement added an `allowClawback` flag in
    the `AccountRoot` object.
  * In the API response, under `account_flags`, there is now an
    `allowClawback` field with a boolean (`true` or `false`) value.
  * For reference, the XLS-39 Clawback implementation can be found in
    XRPLF#4553

Fix XRPLF#4588
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 22, 2023
@shawnxie999 @ckeshava
fix: add allowClawback flag for account_info (XRPLF#4590)
2ce1116 
* Update the `account_info` API so that the `allowClawback` flag is
  included in the response.
  * The proposed `Clawback` amendement added an `allowClawback` flag in
    the `AccountRoot` object.
  * In the API response, under `account_flags`, there is now an
    `allowClawback` field with a boolean (`true` or `false`) value.
  * For reference, the XLS-39 Clawback implementation can be found in
    XRPLF#4553

Fix XRPLF#4588
ckeshava pushed a commit to ckeshava/rippled that referenced this issue Sep 25, 2023
@shawnxie999 @ckeshava
fix: add allowClawback flag for account_info (XRPLF#4590)
102f291 
* Update the `account_info` API so that the `allowClawback` flag is
  included in the response.
  * The proposed `Clawback` amendement added an `allowClawback` flag in
    the `AccountRoot` object.
  * In the API response, under `account_flags`, there is now an
    `allowClawback` field with a boolean (`true` or `false`) value.
  * For reference, the XLS-39 Clawback implementation can be found in
    XRPLF#4553

Fix XRPLF#4588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shawnxie999 shawnxie999

Labels
None yet
Projects
Core Ledger
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@intelliot @ckniffen @shawnxie999