Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate "Not Synced" Error Messages #3418

Closed
wants to merge 4 commits into from
Closed

Consolidate "Not Synced" Error Messages #3418

wants to merge 4 commits into from

Commits on Jun 22, 2020

  1. Consolidate "Not Synced" Error Messages 

    * Fixes XRPLF#3269

* Work on a version 2 of the XRP Network API has begun.
  The new API returns the code `notSynced` in place of
  `noClosed`, `noCurrent`, and `noNetwork`.  And
  `invalidParams` is returned in place of `lgrIdxInvalid`.
* The version 2 API can be specified by adding
  "api_version" = 2 to your json request.  The default
  version remains 1 (if unspecified), except for the command
  line interface which tracks version 2.
    @HowardHinnant
    HowardHinnant committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    554aa89 View commit details
    Browse the repository at this point in the history

  2. handle notSynced in gRPC code

    @cjcobb23 @HowardHinnant
    cjcobb23 authored and HowardHinnant committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    7760766 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2020

  1. [FOLD] Address reviewer comments

    @HowardHinnant
    HowardHinnant committed Jun 23, 2020
    Configuration menu
    Copy the full SHA
    ceaa645 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. [FOLD] Disable the v2 API by ApiMaximumSupportedVersion to 1. 

    * It can be re-enabled by setting ApiMaximumSupportedVersion to 2.
    @HowardHinnant
    HowardHinnant committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    1e1a9ee View commit details
    Browse the repository at this point in the history