Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DinD Service from container build template #3676

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Remove DinD Service from container build template #3676

merged 2 commits into from
Dec 4, 2020

Conversation

northrup
Copy link

@northrup northrup commented Nov 24, 2020 •
edited
Loading

Refactor how our Docker calls are invoked on the GitLab runners using services methods and moving away from Docker-in-Docker.

Remove DinD Service from container build template
fd9f170 
DinD has changed how it works on GItLab due to recent docker changes such that the service no long needs to be called so long as the runner is being run on a `docker-X` tagged machine.
@northrup northrup self-assigned this Nov 24, 2020
@MarkusTeufelberger
Copy link
Collaborator

If you want to get rid of docker build alltogether, I can recommend taking a look at kaniko by the way.

@nbougalis nbougalis mentioned this pull request Dec 4, 2020
Merged
@carlhua carlhua assigned manojsdoshi and unassigned northrup Dec 4, 2020
manojsdoshi
manojsdoshi approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@manojsdoshi manojsdoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbougalis
Copy link
Contributor

Kaniko looks interesting, @MarkusTeufelberger. Thanks for the pointer. This isn't really my field of expertise, so I'll let others decide whether this should be done.

@northrup
Copy link
Author

northrup commented Dec 4, 2020

@MarkusTeufelberger that is a good point, and we have kaniko elsewhere, for the image building that we do that's a good idea and I'll look to refactor those, we also use docker here to spawn build jobs within a CI run.

@northrup northrup merged commit f239050 into develop Dec 4, 2020
@nbougalis nbougalis deleted the dind-refactor branch December 6, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojsdoshi manojsdoshi manojsdoshi approved these changes

Assignees

@manojsdoshi manojsdoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@northrup @MarkusTeufelberger @nbougalis @manojsdoshi