Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace boost::clamp with std::clamp #3903

Closed
wants to merge 1 commit into from
Closed

Replace boost::clamp with std::clamp #3903

wants to merge 1 commit into from

Conversation

HowardHinnant
Copy link
Contributor

Maintenance: Migrate from boost to std code for clamp

Context of Change

There is no functionality change.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

gregtatcam
gregtatcam approved these changes Aug 16, 2021
View reviewed changes
Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

pwang200
pwang200 approved these changes Aug 19, 2021
View reviewed changes
Copy link
Contributor

@pwang200 pwang200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@HowardHinnant HowardHinnant added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Aug 19, 2021
@manojsdoshi manojsdoshi mentioned this pull request Sep 9, 2021
Closed
@nbougalis nbougalis mentioned this pull request Sep 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pwang200 pwang200 pwang200 approved these changes

@gregtatcam gregtatcam gregtatcam approved these changes

Assignees

@pwang200 pwang200

@gregtatcam gregtatcam

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HowardHinnant @pwang200 @gregtatcam