Set OpenSSL 1.1.1 as the minimum version #3935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximinez
added
Build System
Dependencies
seelabs
approved these changes
Sep 27, 2021
|
@seelabs Sorry, I was premature. My quick checks with 3.0.0 looked good, but the longer checks dug up some deprecated functions in 3.0.0 that prevent rippled from building, so I changed the VS README back to 1.1.1L. I'm double-checking with that version now, but since I had previously been using 1.1.1K, I don't anticipate any problems. |
ximinez
changed the title
legleux
approved these changes
Sep 28, 2021
ximinez
added
the
Passed
Closed
* Also clean up some formatting in the Windows instructions
Merged
|
"Merged as part of #3948" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
CMake config defined OpenSSL 1.0.2 as the minimum, even though building rippled would fail with that version for about 6 months. Update it to the newest commonly available version, 1.1.1.
3.0.0 was released a few weeks ago, but I'm not making that the minimum until it has had more time to be used and "shake out" issues, and to be included in more linux distros.
However, I updated the Windows build instructions to recommend 3.0.0, which seems to work well there.Edit: Narrator: 3.0.0 didn't work well there.
I changed the Visual Studio README.md to recommend 1.1.1L.
Context of Change
Builds fail with older versions of OpenSSL. Because OpenSSL is security sensitive, we should keep up our requirements to match the latest version.
OpenSSL is referenced in two places in the CMake config. I don't know why that is, and am leaving that question as outside the scope of this PR.