Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Boost's deque forward declaration #3939

Closed
wants to merge 1 commit into from

Conversation

ximinez
Copy link
Collaborator

@ximinez ximinez commented Oct 1, 2021

High Level Overview of Change

Does what it says on the tin: Defines a build variable that tells Boost to include deque directly instead of trying to predeclare it. That variable is called BOOST_CONTAINER_FWD_BAD_DEQUE,

Context of Change

After upgrading Boost from 1.70 to 1.75, building in Visual Studio 2017 would fail, giving errors about std::deque missing template parameters. The boost/detail/container_fwd.hpp tries to forward declare the std::deque template without specifying default paramters. Defining BOOST_CONTAINER_FWD_BAD_DEQUE simply includes the deque header and removes the forward declaration.

I realized at some point that I had already "fixed" this issue in #3851 with the commit labelled "Add missing "deque" headers in a bunch of places". This fix is simpler and therefore better. It's also now causing problems across branches, so I'm making a separate PR for it.

Type of Change

  • [X ] Bug fix (non-breaking change which fixes an issue)

Test Plan

This is only a build issue. There is nothing to test.

Copy link
Contributor

@cjcobb23 cjcobb23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. LGTM.

Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ximinez ximinez added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Oct 4, 2021
@manojsdoshi manojsdoshi mentioned this pull request Oct 6, 2021
@manojsdoshi
Copy link
Contributor

"Merged as part of #3948"

@manojsdoshi manojsdoshi closed this Oct 7, 2021
@ximinez ximinez deleted the boost_deque branch October 7, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Build System Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants