Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance ripple.app.rdb #3965

Closed
wants to merge 12 commits into from
Closed

Commits on May 3, 2022

  1. Adjust thread count calculation and request bundling:

    This commit addresses minor bugs introduced with commit
    6faaa91:
    
    - The number of threads used by the database engine was
      incorrectly clamped to the lower possible value, such
      that the database was effectively operating in single
      threaded mode.
    
    - The number of requests to extract at once was so high
      that it could result in increased latency. The bundle
      size is now limited to 4 and can be adjusted by a new
      configuration option `rq_bundle` in the `[node_db]`
      stanza. This is an advanced tunable and adjusting it
      should not be needed.
    nbougalis authored and manojsdoshi committed May 3, 2022
    Configuration menu
    Copy the full SHA
    5126366 View commit details
    Browse the repository at this point in the history
  2. Adjust the aggressiveness of the ledger acquisition engine:

    Several hard-coded parameters control the behavior of the ledger
    acquisition engine. The values of many of these parameters where
    set by intuition and have complex and non-intuitive interactions
    with each other and other parts of the code.
    
    An earlier commit attempted to adjust several of these parameters
    to improve syncing performance; initial testing was promising but
    a number of operators reported experiencing syncing and stability
    issues with their servers. As a result, this commit reverts parts
    of commit 1823506.
    
    This commit further adjusts some tunables so as to increase the
    aggressiveness of the ledger acquisition engine.
    nbougalis authored and manojsdoshi committed May 3, 2022
    Configuration menu
    Copy the full SHA
    762171a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6c2ed50 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    558c3e3 View commit details
    Browse the repository at this point in the history
  5. Instead of abending, wait until server stabilizes after

    failing online delete healch check.
    mtrippled authored and manojsdoshi committed May 3, 2022
    Configuration menu
    Copy the full SHA
    6fc5629 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    9519c61 View commit details
    Browse the repository at this point in the history
  7. Don't load trust lines that can't participate in path finding

    * "A path is considered invalid if and only if it enters and exits an
      address node through trust lines where No Ripple has been enabled for
      that address." (https://xrpl.org/rippling.html#specifics)
    * When loading trust lines for an account "Alice" which was reached
      via a trust line that has the No Ripple flag set on Alice's side, do
      not use or cache any of Alice's trust lines which have the No Ripple
      flag set on Alice's side. For typical "end-user" accounts, this will
      return no trust lines.
    ximinez authored and manojsdoshi committed May 3, 2022
    Configuration menu
    Copy the full SHA
    064b5e2 View commit details
    Browse the repository at this point in the history
  8. Track total trustlines, avoid duplications

    * Also remove an unused variable that's giving VS a problem
    ximinez authored and manojsdoshi committed May 3, 2022
    Configuration menu
    Copy the full SHA
    691f938 View commit details
    Browse the repository at this point in the history
  9. Amendment: ExpandedSignerList

    RichardAH authored and manojsdoshi committed May 3, 2022
    Configuration menu
    Copy the full SHA
    bf577fc View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    34efb7c View commit details
    Browse the repository at this point in the history
  11. Set version to 1.9.1-b1

    manojsdoshi committed May 3, 2022
    Configuration menu
    Copy the full SHA
    1f2f50f View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. Advance ripple.app.rdb

    undertome committed May 4, 2022
    Configuration menu
    Copy the full SHA
    6760ad4 View commit details
    Browse the repository at this point in the history