Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update boost version requirement to 1.71 #4134

Closed
wants to merge 2 commits into from
Closed

update boost version requirement to 1.71 #4134

wants to merge 2 commits into from

Conversation

greg7mdp
Copy link
Contributor

@greg7mdp greg7mdp commented Apr 6, 2022 •
edited
Loading

…ilding on M1 mac

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

seelabs
seelabs reviewed Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some minor comments about requiring boost 1.75 instead of 1.71.

I'd also do this with two commits instead of one: One commit to update the boost version and one commit for the changes need to compile on arm.

Builds/VisualStudio2017/README.md Outdated Show resolved Hide resolved
Builds/CMake/deps/Boost.cmake Outdated Show resolved Hide resolved
Builds/linux/README.md Outdated Show resolved Hide resolved
@greg7mdp greg7mdp changed the title update boost version requirement to 1.75, and fix build issue when bu… update boost version requirement to 1.75 Apr 6, 2022
@greg7mdp greg7mdp changed the title update boost version requirement to 1.75 update boost version requirement to 1.71 Apr 6, 2022
@seelabs seelabs removed the request for review from nbougalis April 6, 2022 16:38
@seelabs seelabs requested a review from legleux April 6, 2022 16:38
seelabs
seelabs approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@seelabs seelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

legleux
legleux suggested changes Apr 6, 2022
View reviewed changes
Builds/linux/README.md Outdated
```

Alternatively, you can add `DBOOST_ROOT=~/boost_1_70_0` to the command line when
Alternatively, you can add `DBOOST_ROOT=~/boost_1_71_0` to the command line when
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this file is being touched, this parameter is missing the - i.e. -DBOOST_ROOT=~/boost_1_71_0
I like copy/pasteable things.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks for the suggestion @legleux !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@legleux are you OK to approve the PR now?

@greg7mdp
Copy link
Contributor Author

Thanks for the approval @legleux. Who's merging this now?

@seelabs seelabs added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 13, 2022
This was referenced May 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legleux legleux legleux approved these changes

@seelabs seelabs seelabs approved these changes

Assignees

@legleux legleux

@seelabs seelabs

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@greg7mdp @legleux @seelabs @nbougalis