Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated/unused AccountTxOld.cpp (fix #2926) #4245

Closed
wants to merge 1 commit into from

Conversation

ckeshava
Copy link
Collaborator

If merged, this PR will:

  • delete the deprecated file AccountTxOld.cpp
  • Update the help message in Main.cpp to remove deprecated fields.
  • The unit tests are running correctly. Manual RPC calls to account_tx command are working as expected.

@ckeshava
Copy link
Collaborator Author

I have a question. This file src/ripple/protocol/jss.h has certain references to AccountTxOld and offset in its comments. Shall I remove them as well?

This was referenced Aug 4, 2022
@intelliot intelliot changed the title remove deprecated AccountTxOld.cpp - fix #2926 Remove deprecated/unused AccountTxOld.cpp (fix #2926) Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant