Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce reserves to 10/2 #4329

Merged
merged 3 commits into from
Dec 13, 2022
Merged

Reduce reserves to 10/2 #4329

merged 3 commits into from
Dec 13, 2022

Conversation

alloynetworks
Copy link
Contributor

The current network reserves are 10/2 as against the older 20/5. These reserves have been in force for long enough that new validators should not have to vote explicitly for this.

Reduce the reserve requirements from 20/5 to 10/2 in line with the current network votes. The requirements of 10/2 have been on the network long enough that new nodes should not still have the old reserve amount.
Copy link
Member

@WietseWind WietseWind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏼👌🏼

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several unit tests are failing. It just so happens that I made this same change, and fixed the tests as part of #4247. I think the relevant commit is ac080f2.

Feel free to steal those changes, and this PR can potentially be merged before the other one.

@RichardAH
Copy link
Collaborator

RichardAH commented Oct 26, 2022

Feel free to steal those changes, and this PR can potentially be merged before the other one.

Thanks! It's probably better to keep this PR as simple as possible so that it can be merged quickly. I've just updated the unit tests that were broken. We want to avoid any chance of "fee flip-flopping" in production voting.

@RichardAH
Copy link
Collaborator

Longest suite times:
   63.5s ripple.tx.Offer
   62.4s ripple.tx.NFTokenBurn
   62.1s ripple.tx.NFToken
   44.4s ripple.app.TheoreticalQuality
   35.3s ripple.app.ValidatorSite
   31.3s ripple.rpc.NodeToShardRPC
   30.8s ripple.app.ShardArchiveHandler
   27.5s ripple.tx.NFTokenDir
   23.5s ripple.app.ReportingETL
   18.8s ripple.app.AccountDelete
606.0s, 204 suites, 1527 cases, 532147 tests total, 0 failures

Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tests pass now.

@intelliot intelliot merged commit 0362e93 into XRPLF:develop Dec 13, 2022
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
Reduce the reserve requirements from 20/5 to 10/2 in line with the current network votes. The requirements of 10/2 have been on the network long enough that new nodes should not still have the old reserve amount.

Co-authored-by: Richard Holland <richard.holland@starstone.co.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants