Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doxygen workflow #4372

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Fix Doxygen workflow #4372

merged 1 commit into from
Dec 21, 2022

Conversation

thejohnfreeman
Copy link
Collaborator

@thejohnfreeman thejohnfreeman commented Dec 20, 2022

Add options to selectively build documentation only, which does not depend on the library dependencies of rippled. This lets the Doxygen workflow sidestep the chores of installing and configuring Conan and building and installing libraries.

Here is the successful test of the Doxygen workflow on my fork. The workflow will not run on this PR until it is merged.

Copy link
Collaborator

@legleux legleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@@ -58,6 +58,12 @@ endif ()
include(RippledCompiler)
include(RippledInterface)

option(only_docs "Include only the docs target?" FALSE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who's asking who?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note - just a help string: if you use the cmake GUI, it will show all the options of the project. this will be a label on the option. most people won't see it.

@intelliot intelliot merged commit fda9e9a into XRPLF:develop Dec 21, 2022
@HowardHinnant
Copy link
Contributor

When I pushed this to my repository I got this result: https://github.com/HowardHinnant/rippled/actions/runs/3752317714

Disclaimer: I have no clue what I'm doing.

dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Dec 27, 2022
@thejohnfreeman thejohnfreeman deleted the doxygen branch January 4, 2023 18:57
dangell7 pushed a commit to Transia-RnD/rippled that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants