Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amendment majority flapping: use a more stable threshold for the number of votes required; when missing STValidation, use the last vote seen #4410

Merged
merged 7 commits into from
Sep 28, 2023

Commits on Jun 2, 2023

  1. The fixAmendmentFlapping amendment:

    Amendment flapping usually occurs when an amendment is on
    the verge of gaining majority, and a validator not in favor
    of the amendment goes offline.
    
    If fixAmendmentFlapping activates then two changes occur:
    
    1. The number of validators in the UNL determines the required
    threshold for an amendment to gain majority.
    
    2. The AmendmentTable keeps a record of the most recent
    Amendment vote received from each trusted validator in the
    UNL.  If no validation arrives from a given validator, then
    the AmendmentTable assumes that the previously received vote
    has not changed.
    
    Fixes XRPLF#4350
    scottschurr committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    7a93ad6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d636f1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d001960 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Configuration menu
    Copy the full SHA
    b71de8e View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Configuration menu
    Copy the full SHA
    e3e7a7d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    745eebe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b4cdda1 View commit details
    Browse the repository at this point in the history