Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Linux test matrix #4454

Merged
merged 24 commits into from
Apr 24, 2023
Merged

Expand Linux test matrix #4454

merged 24 commits into from
Apr 24, 2023

Conversation

thejohnfreeman
Copy link
Collaborator

This change makes progress on the goal of #4371. It does not replicate the full matrix implemented in #3851, but it does replicate the 1.ii section of the Linux matrix. It leverages our "heavy" self-hosted runners and my Docker image for a rippled build environment, and demonstrates what I believe is a simple, readable pattern for future matrices.

@intelliot intelliot added CI Continuous Integration Functionality Build System labels Mar 13, 2023
Copy link

@shichengripple001 shichengripple001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@intelliot
Copy link
Collaborator

notes:

  • flaky tests occur on Mac; is there an equivalent of heavy?
    • no. per @shichengripple001 , we may get a Mac mini and use it for our self-hosted runners.
  • this currently removes the Mac job. @thejohnfreeman will add a workflow for Mac.
    • even if it is flaky, we would rather have that, than no job at all.

@intelliot intelliot requested review from drlongle and legleux and removed request for ximinez March 15, 2023 18:11
@drlongle
Copy link
Contributor

Looks good to me.

.github/workflows/macos.yml Outdated Show resolved Hide resolved
cc: /usr/bin/clang-14
cxx: /usr/bin/clang++-14
runs-on: [self-hosted, heavy]
container: thejohnfreeman/rippled-build-ubuntu:12e19cd9034b
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe push a new ubuntu 18.04 image with GCC-10?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 18.04?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we can test it into perpetuity?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I think there's a case to be made to pick one configuration to test on multiple versions of Ubuntu. I don't have an 18.04 image with everything available right now. Won't take me long to make one, but perhaps we can punt that to a future PR?

.github/workflows/nix.yml Show resolved Hide resolved
.github/workflows/macos.yml Show resolved Hide resolved
@intelliot intelliot added this to the 1.11.0 milestone Mar 22, 2023
@thejohnfreeman
Copy link
Collaborator Author

thejohnfreeman commented Apr 7, 2023

I think this is ready to merge with this message:

This change makes progress on the plan in #4371. It does not replicate the full [matrix] implemented in #3851, but it does replicate the 1.ii section of the Linux matrix. It leverages our "heavy" self-hosted runners, and demonstrates a repeatable pattern for future matrices.

[matrix]: https://github.com/XRPLF/rippled/blob/d794a0f3f161bb30c74881172fc38f763d7d46e8/.github/README.md#continuous-integration

@thejohnfreeman thejohnfreeman added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 7, 2023
@intelliot intelliot merged commit 436de0e into XRPLF:develop Apr 24, 2023
@thejohnfreeman thejohnfreeman deleted the matrix branch April 25, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System CI Continuous Integration Functionality Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants