Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If present, set quorum based on command line. #4489

Merged
merged 2 commits into from
Apr 20, 2023
Merged

If present, set quorum based on command line. #4489

merged 2 commits into from
Apr 20, 2023

Conversation

mtrippled
Copy link
Collaborator

@mtrippled mtrippled commented Apr 6, 2023 •
edited by intelliot
Loading

High Level Overview of Change

This ensures that the administator's desired quorum as set by command line is obeyed.

Context of Change

Type of Change

  • [X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Thanks to: @RichardAH

@RichardAH RichardAH mentioned this pull request Apr 6, 2023
Closed
7 tasks
gregtatcam
gregtatcam requested changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@gregtatcam gregtatcam left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just have two minor comments for your consideration.

src/ripple/app/misc/impl/ValidatorList.cpp Outdated Show resolved Hide resolved
src/test/app/ValidatorList_test.cpp Outdated Show resolved Hide resolved
gregtatcam
gregtatcam approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@intelliot intelliot assigned HowardHinnant and unassigned mtrippled Apr 17, 2023
@mtrippled mtrippled added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Apr 20, 2023
@intelliot intelliot merged commit c500396 into XRPLF:develop Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregtatcam gregtatcam gregtatcam approved these changes

@HowardHinnant HowardHinnant HowardHinnant approved these changes

@RichardAH RichardAH Awaiting requested review from RichardAH

Assignees

@HowardHinnant HowardHinnant

Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
Core Ledger
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mtrippled @gregtatcam @HowardHinnant @intelliot