test: add forAllApiVersions helper function

[arihantkothari]

High Level Overview of Change

This PR introduces a new variadic template helper function forAllApiVersions that accepts callables to execute a set of functions over a range of versions, specifically from RPC::apiMinimumSupportedVersion to RPC::apiBetaVersion. This will be useful to avoid duplication of code. (the for loop)

Context of Change

#4552

Type of Change

• New feature (non-breaking change which adds functionality)

[arihantkothari]

The ordering.txt file was changed because of the levelization patch.

[godexsoft]

LGTM. Leaving a few things for you to try out but not required to change them.

[godexsoft]

You don't need the type anywhere inside the body so you could just use auto:

void forAllApiVersions(auto... callables)

You could also constraint it to require to be callable with a version number using a concept:

template<typename T>
concept VersionedTestCallable = requires(T a, uint32_t v) // use same type as real version for `v`
{
    { a(v) } -> std::same_as<void>;
};
// ...
void forAllApiVersions(VersionedTestCallable auto... fs)

Without any of this you still have an ok solution in my opinion.

[arihantkothari]

Hi @godexsoft , sorry for the late reply - I've never practically used concepts before so I was learning about it.

template <typename T>
concept SingleVersionedTestCallable = requires(T a, unsigned int v)
{
    { a(v) } -> std::same_as<void>;
};

template <typename... T>
concept VersionedTestCallable = (... && SingleVersionedTestCallable<T>);
void
forAllApiVersions(VersionedTestCallable auto... testCallable)
//...

It looks like I'll have to do something like this. Does this look good ?

[godexsoft]

Yea, something like that. I'd think my version also works but i may be wrong - i did not check it. You can experiment on godbolt (compiler explorer) and see what works.

[thejohnfreeman]

I think I prefer the loop, perhaps a range-based for-loop over a boost::counting_range, but this is fine.

[intelliot]

Suggested commit message:

test: add forAllApiVersions helper function (#4611)

Introduce a new variadic template helper function, `forAllApiVersions`,
that accepts callables to execute a set of functions over a range of
versions - from RPC::apiMinimumSupportedVersion to RPC::apiBetaVersion.
This avoids the duplication of code.

Context: #4552

[intelliot]

@arihantkothari -

1. Confirm that the commit message suggested above looks good (or offer an alternative)
2. Confirm that this PR is ready to merge (when you confirm, someone will add the Passed label)

[arihantkothari]

@arihantkothari -

1. Confirm that the commit message suggested above looks good (or offer an alternative)
2. Confirm that this PR is ready to merge (when you confirm, someone will add the Passed label)

1. This commit message looks good to me.
2. I can confirm that it is ready to be merged.
   Thanks :)