Rename allowClawback flag to allowTrustLineClawback

[shawnxie999]

High Level Overview of Change

Context of Change

Reason for this change is here XRPLF/XRPL-Standards#119

We would want to be explicit that this flag is exclusively for trustline. For new token types(eg. CFT), they will not utilize this flag for clawback, instead, they will turn clawback on/off on the token-level, which is more versatile.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactor (non-breaking change that only restructures code)
• Tests (You added tests for code that already exists, or your new feature included in this PR)
• Documentation Updates
• Release

[seelabs]

👍

[ledhed2222]

FYI - errant space

[kennyzlei]

delete space commit since last review lgtm

[intelliot]

@kennyzlei @shawnxie999 this is a breaking API change compared to what was in develop prior to merging this PR, right?

If applicable, please add the API Change label.

[intelliot]

I think the Breaking change (fix or feature that would cause existing functionality to not work as expected) checkbox may also need to be checked

[shawnxie999]

@intelliot why would that be? clawback hasn't been released yet, this change would affect no one

[ckeshava]

I'm a bit late, this PR looks good 👍

[kennyzlei]

I think the Breaking change (fix or feature that would cause existing functionality to not work as expected) checkbox may also need to be checked

@intelliot I don't believe this is a breaking change either. The flag was renamed but the value of the flag is still the same (16). If any previous API usage was using the previous name, it should continue to work. Currently in devnet, this amendment is still not enabled, so there should not be any usage there

edit: I guess there is an API change in the response of the account_info endpoint if someone had the past version deployed with amendment on and switched to this new version. in our current release process, this did not happen but it could have theoretically happened with any commit in develop being available to be released. this could be considered a breaking change in that case

[intelliot]

This is a breaking change to version 1.12.0-b1 which included the original Clawback implementation, and needs to be considered for docs and client libraries, which often only look at PRs labeled API Change when considering the changes to document and implement. For example, #4612 is only considering PRs with the API Change label.