Update minimum compiler requirements in BUILD.md #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the minimum compiler requirements for building the codebase. I'm quite confident that GCC 11 is required, but I'm unsure if older versions of apple-clang is compatible with the latest revisions to the codebase. I'm using apple clang v14.0.3, let me know if any lower version also works with the rippled codebase.
thejohnfreeman
requested changes
Sep 22, 2023
BUILD.md
Outdated
| | Clang | 13 | | ||
| | Apple Clang | 13.1.6 | | ||
| | Apple Clang | 14.0.3 | |
There was a problem hiding this comment.
using enum is supported in Clang 13. Let's not change that minimum requirement until we know for sure that we need it.
There was a problem hiding this comment.
ok. but is there any disadvantage to upgrading directly to 14? since the code has been working with clang 14, I assumed we could upgrade. But I don't have strong opinions about this
There was a problem hiding this comment.
It's ok for a builder to upgrade. We don't want to tell people they have to upgrade if there is no reason to upgrade. These are minimum required versions.
thejohnfreeman
approved these changes
Sep 22, 2023
legleux
approved these changes
Oct 2, 2023
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Update minimum compiler requirement for building the codebase. The
feature "using enum" is required. This feature was introduced in C++20.
Updating the C++ compiler to version 11 or later fixes this error:
```
Building CXX object CMakeFiles/xrpl_core.dir/src/ripple/protocol/impl/STAmount.cpp.o
/build/ripple/binary/src/ripple/protocol/impl/STAmount.cpp: In lambda function:
/build/ripple/binary/src/ripple/protocol/impl/STAmount.cpp:1577:15: error: expected nested-name-specifier before 'enum'
1577 | using enum Number::rounding_mode;
| ^~~~
```
Fix XRPLF#4693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the minimum compiler requirements for building the codebase.
I'm quite confident that GCC 11 is required, but I'm unsure if older versions of apple-clang is compatible with the latest revisions to the codebase. I'm using apple clang v14.0.3, let me know if any lower version also works with the rippled codebase.
Fix #4693
High Level Overview of Change
Context of Change
Type of Change