Add .build to .gitignore #4722
Merged
Add .build to .gitignore #4722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggested in-tree build directory should be automatically excluded from git workspace, so users aren't confused when following instructions
intelliot
reviewed
Sep 22, 2023
|
An alternative improvement is to amend |
|
Personally, I prefer to have every useful exclude in the project-level |
thejohnfreeman
approved these changes
Sep 22, 2023
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
Currently, the `BUILD.md` instructions suggest using `.build` as the build directory, so this change helps to reduce confusion. An alternative would be to instruct developers to add `/.build/` to `.git/info/exclude` or to user-level `.gitignore` (although the latter is very intrusive). However, it is being added here because it is a good practice to have a sensible default that's consistent with the build instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested in-tree build directory should be automatically excluded from git workspace, so users aren't confused when following instructions
Type of Change
Non-functional change