Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate grpc port info in GRPCServer ctor #4728

Merged
merged 11 commits into from
Feb 7, 2024
Merged

Validate grpc port info in GRPCServer ctor #4728

merged 11 commits into from
Feb 7, 2024

Commits on Sep 25, 2023

  1. Fix XRPLF#4015, XRPLF#4557: Do not validate GRPC IP/Port/Protocol inf… 

    …ormation in ServerHandler. Pass the responsibility of grpc port information validation to GRPCServer constructor. Both GRPCServer and ServerHandler are created during the construction of Application instance.

Introduce a constant (SECTION_PORT_GRPC) for port_grpc configuration section

Replace all usages of "port_grpc" raw string with a constant

Created macros for "port_ws", "port_rpc" and "port_peer" for unit test files.
Removed unused imports in some files
    @ckeshava
    ckeshava committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    47f55ae View commit details
    Browse the repository at this point in the history

  2. fix the compiler error by including ConfigSections in ServerInfo unit… 

    … test
    @ckeshava
    ckeshava committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    54d443a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. use const& whereever possible, addressing Ed's suggestions

    @ckeshava
    ckeshava authored Sep 27, 2023
    Configuration menu
    Copy the full SHA
    dc4a1be View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. alphabetically order the #defines

    @ckeshava
    ckeshava committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    429593d View commit details
    Browse the repository at this point in the history

  2. alphabetically order all the #defines (not relevant to the GRPCServer… 

    … issue at hand)
    @ckeshava
    ckeshava committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f61e718 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into grpc3

    @ckeshava
    ckeshava authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2f882af View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Merge branch 'develop' into grpc3

    @intelliot
    intelliot authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    52beb3f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2023

  1. Merge branch 'develop' into grpc3

    @intelliot
    intelliot authored Dec 2, 2023
    Configuration menu
    Copy the full SHA
    33f51ca View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Merge branch 'develop' into grpc3

    @intelliot
    intelliot authored Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9212481 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Merge branch 'develop' into grpc3

    @intelliot
    intelliot authored Feb 5, 2024
    Configuration menu
    Copy the full SHA
    724492d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. Merge branch 'develop' into grpc3

    @intelliot
    intelliot authored Feb 7, 2024
    Configuration menu
    Copy the full SHA
    f7dd7b8 View commit details
    Browse the repository at this point in the history