Destroy tx sets outside of lock. #4761
Open
+122
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottschurr
reviewed
Nov 9, 2023
There was a problem hiding this comment.
This looks pretty good. I left a few comments for your consideration. Feel free to push back on any of them.
FWIW, I did confirm that destroying a std::vector<TxSet_t> occasionally can take over a 100 microseconds. So I understand the motivation for the change.
HowardHinnant
approved these changes
Nov 15, 2023
scottschurr
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
👍 Looks good as far as I'm concerned. However clang-format is complaining. If you want you can cherry-pick the topmost commit here which will hopefully deal with the clang-format: https://github.com/scottschurr/rippled/commits/markt-garbage
mtrippled
added
the
Passed
intelliot
added
Perf Attn Needed
|
Internal tracker: RPFC-84 @mtrippled - could you resolve the merge conflicts? |
intelliot
added
Perf Test Desired (Optional)
|
Currently blocked because this depends on #4505 (which was reverted) |
intelliot
added
Blocked
and removed
Passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This is a performance enhancement that moves destruction of objects that are time consuming to destroy outside of locks.
As transaction volume increases, so does the size of transaction sets for each ledger. This makes it more time-consuming to destroy. Prior to the change, they were destroyed synchronously while in consensus operations, which directly caused consensus to take longer. This change moves unused tx sets into a function that executes on the job queue. Destruction is automatic that way.
Context of Change
Type of Change
Throughput increases after the change. Also, the duration of consensus is reduced under high volumes, such as >4000/s.
Note: This depends on re-introduction of #4505.