Fix 2.0 regression in tx method with binary output #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bronek
force-pushed
the
bugfix/binary_tx_output
branch
from
57613e5 to
d6098b4
Compare
Merged
arihantkothari
approved these changes
Nov 13, 2023
ximinez
requested changes
Nov 14, 2023
ximinez
approved these changes
Nov 15, 2023
| @@ -791,13 +791,13 @@ class Transaction_test : public beast::unit_test::suite | |||
| auto const USD{gw["USD"]}; | |||
|
|
|||
| env.fund(XRP(1000000), alice, gw); | |||
| std::shared_ptr<STTx const> txn = env.tx(); | |||
| std::shared_ptr<STTx const> const txn = env.tx(); | |||
There was a problem hiding this comment.
On second thought, you're calling getTransactionID four times. Why not store it here, and use it at all of the calls?
uint256 const txID = txn->getTransactionID();
(You'll have to change the lambda capture to get &txID instead of txn.)
manojsdoshi
added a commit
that referenced
this pull request
Nov 20, 2023
* Support for the mold linker (#4807) * Promote API version 2 to supported (#4803) * Promote API version 2 to be supported * Switch the command line to API version 1 * Fix LedgerRequestRPC test * Remove obsolete tx_account method This method is not implemented, the only parts which are removed are related to command-line parsing * Fix RPCCall test * Reduce diff size, small test improvements * Minor fixes * Support for the mold linker * Fix TransactionEntry_test * Fix AccountTx_test --------- Co-authored-by: seelabs <scott.determan@yahoo.com> * Update Linux smoketest distros (#4813) * Fix 2.0 regression in tx method with binary output (#4812) * Fix binary output from tx method * Formatting fix * Minor test improvement * Minor test improvements * Optimize calculation of close time to avoid impasse and minimize gratuitous proposal changes (#4760) * Optimize the calculation of close time to avoid impasse and minimize gratuitous proposal changes. * git apply clang-format.patch * Scott S review fixes. Also clang-format. * Set version to 2.0.0-rc2 --------- Co-authored-by: manoj <mdoshi@ripple.com> Co-authored-by: Scott Determan <scott.determan@yahoo.com> Co-authored-by: Bronek Kozicki <brok@incorrekt.com> Co-authored-by: Michael Legleux <legleux@users.noreply.github.com> Co-authored-by: Mark Travis <mtrippled@users.noreply.github.com>
ximinez
pushed a commit
to ximinez/rippled
that referenced
this pull request
Nov 21, 2023
* Fix binary output from tx method * Formatting fix * Minor test improvement * Minor test improvements
manojsdoshi
pushed a commit
to manojsdoshi/rippled
that referenced
this pull request
Nov 21, 2023
* Fix binary output from tx method * Formatting fix * Minor test improvement * Minor test improvements
sophiax851
pushed a commit
to sophiax851/rippled
that referenced
this pull request
Jun 12, 2024
* Fix binary output from tx method * Formatting fix * Minor test improvement * Minor test improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Fixes regression caused by #4775
This PR resolves #4811
Context of Change
The
STTx::getJsonwas changed in API version 2 to allow for returning binary output as a single hex-encoded JSON string (not a JSON object). This caused regression insideTransaction::getJsonwhich will attempt to append fields to that not-an-object, resulting in failed JSON operation. This change is fixing this regression and adds a relevant test.Type of Change
.gitignore, formatting, dropping support for older tooling)