Add xrpld build option and Conan package test #5052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godexsoft
approved these changes
Jun 24, 2024
examples/example/src/example.cpp
Outdated
|
|
||
| #include <xrpl/protocol/BuildInfo.h> | ||
|
|
||
| int main(int argc, const char** argv) { |
There was a problem hiding this comment.
nit: I thought rippled codebase preferred east-const, not that it matters ☝️
|
@Bronek this is still awaiting your review 🙇 |
Bronek
approved these changes
Jun 28, 2024
|
I renamed the option to be more consistent with the other option names (especially |
thejohnfreeman
changed the title
thejohnfreeman
added
the
Passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5052 +/- ##
=======================================
Coverage 71.4% 71.4%
=======================================
Files 796 796
Lines 67031 67031
Branches 10865 10865
=======================================
+ Hits 47831 47833 +2
+ Misses 19200 19198 -2 see 3 files with indirect coverage changes |
13 tasks
ximinez
pushed a commit
that referenced
this pull request
Jul 23, 2024
vlntb
pushed a commit
to vlntb/rippled
that referenced
this pull request
Aug 23, 2024
* Make xrpld target optional * Add job to test Conan recipe * [fold] address review comments * [fold] Enable tests in workflows * [fold] Rename with_xrpld option * [fold] Fix grep expression
vlntb
pushed a commit
to vlntb/rippled
that referenced
this pull request
Aug 23, 2024
* Document the need to specify "xrpld" and "tests" to build and test rippled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5028. The Clio trigger from that branch needs to be merged with this one.