Amendment default votes and retirement #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mDuo13
commented
Nov 20, 2021
mDuo13
commented
- Adds mention of unconditionalized amendments (XLS-11d)
- Documents Refactor Feature name management and creation: (Improve amendment management and default votes) rippled#3877
|
Link check report. 337608 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/amendment_default_votes/ |
JST5000
reviewed
Nov 22, 2021
| @@ -223,6 +225,15 @@ TrustSetAuth | |||
| ``` | |||
|
|
|||
|
|
|||
| ## Retiring Amendments | |||
There was a problem hiding this comment.
This title makes me think that we're talking about how to make amendments stop working, but it seems to be actually referring to "forgetting" code from before a certain amendment. Maybe something like "Retiring Old Behavior" would be more accurate, but it's also not that intuitive...
|
Link check report. 337608 links checked. Preview: https://XRPLF.github.io/xrpl-dev-portal/pr-preview/amendment_default_votes/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.