test: run tests on python 3.12 #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvadari
changed the title
ckeshava
reviewed
Feb 16, 2024
ckeshava
reviewed
Feb 16, 2024
| @@ -2,7 +2,7 @@ name: Unit test | |||
|
|
|||
| on: | |||
| push: | |||
| branches: [master] | |||
| branches: [main] | |||
| pull_request: | |||
| workflow_dispatch: | |||
|
|
|||
There was a problem hiding this comment.
the lint-and-type-check job is executed only on Python 3.7. It shouldn't cause any issue unless there is a breaking change in the linter in between python versions. Should we change it? What do you think?
There was a problem hiding this comment.
That is on purpose, to ensure backwards compatibility. It used to be done on the latest version, but a non-backwards-compatible typing issue was found.
There was a problem hiding this comment.
That change could also be done in a separate PR, since it's irrelevant to this PR.
ckeshava
approved these changes
Feb 16, 2024
jonathanlei
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title says it all.
Context of Change
I was running something on Python 3.12 and wanted to make sure everything would work properly.
Type of Change
Did you update CHANGELOG.md?
Test Plan
CI passes.