Support for PriceOracles #701
Conversation
…s, tecError codes
…atibility with definitions.json, update integration tests
remove extraneous debug print statements
…json - oracle_set and oracle_delete
| errors = super()._get_errors() | ||
|
|
||
| # If price_data_series is not set, do not perform further validation | ||
| if "price_data_series" not in errors and ( |
There was a problem hiding this comment.
| if "price_data_series" not in errors and ( | |
| if self.price_data_series and ( |
There was a problem hiding this comment.
these two statements are not equivalent. surprisingly, self.price_dataa-series is interpreted as an [Object object], even when it is not specified as an input by the user
There was a problem hiding this comment.
self.price_data_series **
Co-authored-by: pdp2121 <71317875+pdp2121@users.noreply.github.com>
|
c'mon guys, please approve the PR soon! we've had enough back and forth :) |
Co-authored-by: Omar Khan <khancodegt@gmail.com>
Co-authored-by: Omar Khan <khancodegt@gmail.com>
| transaction_type: TransactionType = field( | ||
| default=TransactionType.ORACLE_DELETE, | ||
| init=False, | ||
| ) |
There was a problem hiding this comment.
The only tem... error code pertaining to OracleDelete stems from a misuse of the Flags field. Since none of the transactions OracleSet or OracleDelete, the request GetAggregatePrice or the LedgerEntry Oracle make use of a non-zero Flag, I chose to not model it.
Consequently, there are no other tem... errors pertaining to this transaction
|
I have resolved those comments which I could address -- If any of the reviewers prefer to resolve the comments yourself, please let me know. |
|
thanks to all the reviewers for patiently working through this PR. If there are any other comments, please let me know. I'll create a separate PR. |
High Level Overview of Change
This PR adds client library support for Price Oracle amendment.
Please refer to the spec: XRPLF/XRPL-Standards#129
CPP Implementation: XRPLF/rippled#4789
Context of Change
Support for transactions
OracleSetandOracleDeletehas been added.GetAggregatePricerequest is included in the client library.Type of Change
Did you update CHANGELOG.md?
Test Plan
Unit, Integration and snippet tests have been included. There is some overlap between integration and snippet tests, perhaps they could be streamlined better.