Support for NetworkID #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
============================================
+ Coverage 90.44% 90.46% +0.02%
- Complexity 1464 1468 +4
============================================
Files 285 287 +2
Lines 4164 4174 +10
Branches 339 339
============================================
+ Hits 3766 3776 +10
Misses 277 277
Partials 121 121
|
sappenin
reviewed
Aug 3, 2023
| * No-args constructor. | ||
| */ | ||
| public NetworkIdSerializer() { | ||
| super(NetworkId.class, false); |
There was a problem hiding this comment.
Suggested change
| super(NetworkId.class, false); | |
| super(NetworkId.class); |
sappenin
approved these changes
Aug 3, 2023
| @@ -134,9 +136,10 @@ public void serializeAccountDelete() throws JsonProcessingException { | |||
| .sequence(UnsignedInteger.valueOf(2470665)) | |||
| .destination(Address.of("rPT1Sjq2YGrBMTttX4GZHjKu9dyfzbpAYe")) | |||
| .destinationTag(UnsignedInteger.valueOf(13)) | |||
| .networkId(NetworkId.of(UnsignedInteger.MAX_VALUE)) | |||
There was a problem hiding this comment.
Let's add one test that is explicitly indicates (via its name) that the test is testing the absence of a network id on a particular transaction's binary encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
NetworkIDtransaction field. This field isOptionalinTransaction, as it is only required on networks with ID > 1024.Fixes #427