Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Rename HandBoundsMode to HandBoundsLOD for better understanding #200

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

FejZa
Copy link
Contributor

@FejZa FejZa commented Nov 10, 2020

XRTK - Mixed Reality Toolkit Pull Request

Overview

Please see XRTK/com.xrtk.core#677

@StephenHodgson
Copy link
Contributor

I believe we need to update to the new xrtk.core upm preview version and this should be good to go

@FejZa
Copy link
Contributor Author

FejZa commented Nov 11, 2020

You mean updating the Core module commit? Or do we have to actually release the preview package for the checks to work?

@StephenHodgson
Copy link
Contributor

I meant to update the preview package in upm

@StephenHodgson
Copy link
Contributor

The preview release is already out, so just need to go into the unity package manager and update it in the project manifest

@FejZa
Copy link
Contributor Author

FejZa commented Nov 12, 2020

Sorry but I am a bit confused here. In which project do I have to update the Core preview package?

@StephenHodgson
Copy link
Contributor

The SDK Project

@FejZa
Copy link
Contributor Author

FejZa commented Nov 12, 2020

Ah I see. Never ever opened up any of the submodule projects and didn't think about them.

@FejZa
Copy link
Contributor Author

FejZa commented Nov 12, 2020

So far I thought they are useless.

@StephenHodgson
Copy link
Contributor

No worries, it is only needed if there is breaking change from upstream

@StephenHodgson
Copy link
Contributor

Lol they're aren't useless. You can open either as part of core (which pulls in all the projects), or open each individually. It really doesn't matter. It's just much easier to work in the core project when you're doing breaking changes or working on core functionality and want to update across all packages.

@StephenHodgson
Copy link
Contributor

If you're working on platform specific stuff you could stick to a single project.

@StephenHodgson
Copy link
Contributor

Once tests pass we can merge

@StephenHodgson StephenHodgson merged commit dc15c91 into development Nov 12, 2020
@StephenHodgson StephenHodgson deleted the dev/hand-bounds-mode-rename branch November 12, 2020 22:13
XRTK-Build-Bot pushed a commit that referenced this pull request Dec 25, 2020
* Rename HandBoundsMode to HandBoundsLOD

* Bump core dependency
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants