-
Notifications
You must be signed in to change notification settings - Fork 3
Rename HandBoundsMode to HandBoundsLOD for better understanding #200
Conversation
I believe we need to update to the new xrtk.core upm preview version and this should be good to go |
You mean updating the Core module commit? Or do we have to actually release the preview package for the checks to work? |
I meant to update the preview package in upm |
The preview release is already out, so just need to go into the unity package manager and update it in the project manifest |
Sorry but I am a bit confused here. In which project do I have to update the Core preview package? |
The SDK Project |
Ah I see. Never ever opened up any of the submodule projects and didn't think about them. |
So far I thought they are useless. |
No worries, it is only needed if there is breaking change from upstream |
Lol they're aren't useless. You can open either as part of core (which pulls in all the projects), or open each individually. It really doesn't matter. It's just much easier to work in the core project when you're doing breaking changes or working on core functionality and want to update across all packages. |
If you're working on platform specific stuff you could stick to a single project. |
Once tests pass we can merge |
* Rename HandBoundsMode to HandBoundsLOD * Bump core dependency
XRTK - Mixed Reality Toolkit Pull Request
Overview
Please see XRTK/com.xrtk.core#677