Skip to content
This repository has been archived by the owner on Aug 11, 2024. It is now read-only.

Rename HandBoundsMode to HandBoundsLOD for better understanding #677

Merged
merged 3 commits into from
Nov 11, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Submodules/Oculus
2 changes: 1 addition & 1 deletion Submodules/SDK
Submodule SDK updated from 70688a to c3d7ff
2 changes: 1 addition & 1 deletion Submodules/Ultraleap
2 changes: 1 addition & 1 deletion Submodules/WindowsMixedReality
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ public abstract class BaseHandControllerDataProviderProfile : BaseMixedRealityCo

[SerializeField]
[Tooltip("Set the bounds mode to use for calculating hand bounds.")]
private HandBoundsMode boundsMode = HandBoundsMode.Hand;
private HandBoundsLOD boundsMode = HandBoundsLOD.Low;

/// <summary>
/// Set the bounds mode to use for calculating hand bounds.
/// </summary>
public HandBoundsMode BoundsMode => boundsMode;
public HandBoundsLOD BoundsMode => boundsMode;

[SerializeField]
[Tooltip("Tracked hand poses for pose detection.")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,17 @@ namespace XRTK.Definitions.Controllers.Hands
/// <summary>
/// Available hand bounds modes.
/// </summary>
public enum HandBoundsMode
public enum HandBoundsLOD
{
/// <summary>
/// Hand bounds mode will only calculate a single bounding
/// box encapsulating the whole hand.
/// </summary>
Hand = 0,
Low = 0,
/// <summary>
/// Fingers bounds mode will create precise bounds for each finger
/// and the palm to allow for more precise interactions.
/// </summary>
Fingers
High
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ public class SimulatedHandControllerDataProviderProfile : SimulatedControllerDat

[SerializeField]
[Tooltip("Set the bounds mode to use for calculating hand bounds.")]
private HandBoundsMode boundsMode = HandBoundsMode.Hand;
private HandBoundsLOD boundsMode = HandBoundsLOD.Low;

/// <summary>
/// Set the bounds mode to use for calculating hand bounds.
/// </summary>
public HandBoundsMode BoundsMode => boundsMode;
public HandBoundsLOD BoundsMode => boundsMode;

[SerializeField]
[Tooltip("Tracked hand poses for pose detection.")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,12 @@ public SystemType GazeProviderType

[SerializeField]
[Tooltip("Set the bounds mode to use for calculating hand bounds.")]
private HandBoundsMode boundsMode = HandBoundsMode.Hand;
private HandBoundsLOD boundsMode = HandBoundsLOD.Low;

/// <summary>
/// Set the bounds mode to use for calculating hand bounds.
/// </summary>
public HandBoundsMode BoundsMode => boundsMode;
public HandBoundsLOD BoundsMode => boundsMode;

[SerializeField]
[Tooltip("Hand controller poses tracked.")]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,6 @@ public interface IMixedRealityHandControllerDataProvider : IMixedRealityControll
/// <summary>
/// Gets the configured hand bounds mode to be used with hand physics.
/// </summary>
HandBoundsMode BoundsMode { get; set; }
HandBoundsLOD BoundsMode { get; set; }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ protected BaseHandControllerDataProvider(string name, uint priority, BaseHandCon
public bool UseTriggers { get; set; }

/// <inheritdoc />
public HandBoundsMode BoundsMode { get; set; }
public HandBoundsLOD BoundsMode { get; set; }

/// <summary>
/// Configured <see cref="HandControllerPoseProfile"/>s for pose recognition.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,11 @@ private void UpdateBounds()
{
var handControllerDataProvider = (IMixedRealityHandControllerDataProvider)ControllerDataProvider;

if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsMode.Hand)
if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsLOD.Low)
{
UpdateHandBounds();
}
else if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsMode.Fingers)
else if (handControllerDataProvider.HandPhysicsEnabled && handControllerDataProvider.BoundsMode == HandBoundsLOD.High)
{
UpdatePalmBounds();
UpdateThumbBounds();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public SimulatedHandControllerDataProvider(string name, uint priority, Simulated
public bool UseTriggers { get; set; }

/// <inheritdoc />
public HandBoundsMode BoundsMode { get; set; }
public HandBoundsLOD BoundsMode { get; set; }

/// <inheritdoc />
public HandRenderingMode RenderingMode { get; set; }
Expand Down