This repository has been archived by the owner on May 13, 2022. It is now read-only.
Add support for input and gestures for hand controllers #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Controllers/WindowsMixedRealityController.cs
fixed naming for controller definition
…lity into feature/hand-input
FejZa
added
Ready for review
SimonDarksideJ
previously approved these changes
Sep 21, 2020
StephenHodgson
previously requested changes
Sep 21, 2020
XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Runtime/Utilities/WindowsApiChecker.cs
Outdated
Show resolved
Hide resolved
|
What compiler errors? This is building fine for me. |
|
The CI is saying there's script compiler errors |
|
@StephenHodgson yep, just looking into that. Confusing me a lot. Those errors do not appear locally and do not make any sense since the namespace is defined and the classes available. |
|
I think it's resolved now. I just started a new run. |
|
|
Yeah I saw that error. But it's not true. |
|
I think it might be bc we're not properly installing the UWP Build support in a prev step... |
|
I'd recommend merging this along with the other PR's, and resolve the build server issue separately. Considering this builds and runs fine locally. |
SimonDarksideJ
approved these changes
Sep 22, 2020
|
@SimonDarksideJ were you able to build and deploy on your end? |
XRTK-Build-Bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
* updated wmr controller data provider * removed commented out class * added controller data provider reference to the controller * updated references * fixed references * Added default controller definitions * updated the controller data provider inspector fixed naming for controller definition * updated hand data provider profile inspector * removed redundant inspector * cleaned up the controller interaction mappings a bit * updated references * updated controller instance creation * added default constructor * updated TryRenderController method * removed asset menu * fixed compiler error * Remove obsolete SetupDefaultIntreactions (#65) * updated reference * added WMR Camera Data Provider * updated WMR Camera Data Provider * updated camera rig reference * updated icon * moved WMR Camera data provider into correct file location * updated data provider constructors * added service parent reference * Change requests for controller provider inspectors (#67) * Update indent levels for WMR settings * Cache GUIContent * Adjust WMR to recent core changes * Update due to rename * Cleanup usings * Added rig reset override * reverted changes * removed unused reference * added camera profile * Updated windows controller type name to get the controller textures to show up correctly based on the type name * fixed reference to renamed controller class * fixed more type references * Resolve merge issues * Reset some unrelated file changes * Fix namespace * Moved WMR hand data provider profile asset * Fix WMR namespace compiler error * Cleanup namespace * Move default wmr data provider profile from SDK * Update profile references * Introduce hand rendering mode * Implement runtime rendering mode switch * Update converter to define platform capabilities * Update wmr to use post processor * Fix build errors due to removal of base converter * Rename joints * Point to new hand controller profiles * Pass handedness to pose recognizer * Fix build errors * Update WMR converter to latest changes * Update wmr hand data provider * Temp update WindowsApiChecker * Fix joint-root offset calculation * Finally fix freaking joint conversion * Cleanup code * Commit new controller GUIDs * Implement pointer pose override for WMR platform * Remove DOTNETWINRT_PRESENT usage Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Companion PR to XRTK/com.xrtk.core#552