Update WindowsApiChecker and usage #92
Conversation
Introduced `IsTypeAvailable`, `IsMethodAvailable` and `IsPropertyAvailable`
|
Why did it stop working tho? |
|
Not sure. I can only guess that |
|
I mean it's part of the windows API. That's not going anywhere. Did you recently update your os? |
....WindowsMixedReality/Packages/com.xrtk.wmr/Runtime/Extensions/InteractionSourceExtensions.cs
Outdated
Show resolved
Hide resolved
| @@ -440,10 +440,24 @@ private WindowsMixedRealityMotionController GetController(InteractionSource inte | |||
| private static async void TryRenderControllerModel(InteractionSource interactionSource, WindowsMixedRealityMotionController controller) | |||
| { | |||
| #if WINDOWS_UWP | |||
| if (!UnityEngine.XR.WSA.HolographicSettings.IsDisplayOpaque) { return; } | |||
| if (!UnityEngine.XR.WSA.HolographicSettings.IsDisplayOpaque) | |||
There was a problem hiding this comment.
We already check if the hmd is opaque using the camera rig. Let's remove the unity dependencies
There was a problem hiding this comment.
But does that check in the camera rig affect rendering controller models? Also this is not a change of this PR. I only moved the { return } to the next line.
There was a problem hiding this comment.
Then I suggest changing this test to use the Camera.isOpaque rather than the Unity dependency.
If the option isn't visible, then fix that.
XRTK.WindowsMixedReality/Packages/com.xrtk.wmr/Runtime/Utilities/WindowsApiChecker.cs
Outdated
Show resolved
Hide resolved
|
I'd like to possibly do another pass at this and remove all the strings and use |
* Remove obsolete APIs from WindowsApiChecker Introduced `IsTypeAvailable`, `IsMethodAvailable` and `IsPropertyAvailable` * Update InteractionSourceExtensions.cs * Update WindowsMixedRealityControllerDataProvider.cs * Remove DOTNETWINRT_PRESENT usage Co-authored-by: Stephen Hodgson <hodgson.designs@gmail.com>
XRTK - Mixed Reality Toolkit Pull Request
Overview
Updated the
WindowsApiCheckerand removed obsolete APIs.Introduced
WindowsApiChecker.IsMethodAvailable,WindowsApiChecker.IsPropertyAvailableandWindowsApiChecker.IsTypeAvailable.As hands stopped working for HoloLens 2 I identified the WindowsApiChecker as the root of the problem and updated accordingly.
Changes
Introduced
WindowsApiChecker.IsMethodAvailable,WindowsApiChecker.IsPropertyAvailableandWindowsApiChecker.IsTypeAvailable.Removed obsolete contract checker prorperties and updated api checker to latest MRTK status and usage.
Breaking Changes
WindowsApiChecker.UniversalApiContractVX_IsAvailable