This repository has been archived by the owner on May 13, 2022. It is now read-only.
Updated WMR controller config layout, to support #664 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonDarksideJ
added
the
Ready for review
|
Were these files removed from another package and added to this one? |
If I removed them from the SDK, then OpenVR wouldn't work :D |
|
Well we get conflicts if they're not removed? Or are these changed enough to be unique? |
again, tested and no, it doesn't conflict. As when we import the profiles from their hidden folders, all the GUID's get regenerated. So no conflicts |
FejZa
approved these changes
Sep 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRTK - Mixed Reality Toolkit Pull Request
Overview
WMR Controller Input Action mappings were depending on the OpenVR controller input action mappings, however when these were moved to the WMR package, the mappings were not moved too.
Changes
Added Controller Input Action mappings for WMR controllers
Reorganized assets to match SDK
Fixes: Configuration profiles for NON-SDK packages do not seem to import correctly com.xrtk.core#664