Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade OTel to version 1.14.0/0.37.0 #150

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Upgrade OTel to version 1.14.0/0.37.0 #150

merged 2 commits into from
Mar 2, 2023

Conversation

aaronjheng
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 1, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.0% and no project coverage change

Comparison is base (96bc915) 80.2% compared to head (a04a77b) 80.2%.

Additional details and impacted files 
@@          Coverage Diff          @@
##            main    #150   +/-   ##
=====================================
  Coverage   80.2%   80.2%           
=====================================
  Files         13      13           
  Lines        652     652           
=====================================
  Hits         523     523           
  Misses       105     105           
  Partials      24      24
Impacted Files Coverage Δ
instruments.go 60.6% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aaronjheng aaronjheng changed the title Bump go.opentelemetry.io/otel Upgrade OTel to version 1.14.0/0.37.0 Mar 1, 2023
@aaronjheng aaronjheng marked this pull request as ready for review March 1, 2023 03:42
@aaronjheng aaronjheng requested a review from XSAM as a code owner March 1, 2023 03:42
This was referenced Mar 1, 2023
Closed
Closed
Merged
Closed
julienschmidt
julienschmidt reviewed Mar 1, 2023
View reviewed changes
example/go.sum
@@ -1,502 +1,67 @@
cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was probably deleted / not regenerated by accident?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. I just ran go mod tidy.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not in the example/ dir? Otherwise there should still be a go.sum 🤔

XSAM
XSAM reviewed Mar 2, 2023
View reviewed changes
Copy link
Owner

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronjheng Thank you for the PR.

Overall good, some comments need to be resolved.

instruments.go Show resolved Hide resolved
sql_test.go Show resolved Hide resolved
@XSAM XSAM merged commit da6f3f6 into XSAM:main Mar 2, 2023
@XSAM
Copy link
Owner

XSAM commented Mar 2, 2023

@aaronjheng Thank you for your contribution.

@aaronjheng aaronjheng deleted the metric branch March 2, 2023 23:12
@natewoods-wf
Copy link

👋 Thanks for doing the work here @aaronjheng! Any word/timeline on pushing a tag with this @XSAM?

@XSAM
Copy link
Owner

XSAM commented Mar 2, 2023

Hi @natewoods-wf, I will make a release later this day.

@XSAM XSAM mentioned this pull request Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienschmidt julienschmidt julienschmidt left review comments

@XSAM XSAM XSAM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronjheng @XSAM @natewoods-wf @julienschmidt