Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splithttp with alpn http/1.1 doesn't work ! #3566

Closed
ghost opened this issue Jul 20, 2024 · 1 comment · Fixed by #3567
Closed

Splithttp with alpn http/1.1 doesn't work ! #3566

ghost opened this issue Jul 20, 2024 · 1 comment · Fixed by #3567
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Jul 20, 2024

https://github.com/XTLS/Xray-core/releases/tag/v1.8.20

SplitHTTP 服务端支持 H2C，客户端支持 HTTP/1.1+TLS
SplitHTTP server supports H2C, client supports HTTP/1.1+TLS

But it doesn't work when alpn is http/1.1 !
@ghost ghost changed the title alpn http/1.1 doesn't work ! Splithttp with alpn http/1.1 doesn't work ! Jul 20, 2024
@mmmray
Copy link
Collaborator

mmmray commented Jul 20, 2024

it seems TLS settings do not get applied on the server at all. The issue got introduced in #3554 and the tests gave a false sense of security and were ineffective in catching it. I'm fixing this issue now.

Please, next time give a better bug report so I don't have to fish for issues.

@mmmray mmmray added the bug Something isn't working label Jul 20, 2024
@mmmray mmmray mentioned this issue Jul 20, 2024
Merged
@mmmray mmmray closed this as completed in 22753e9 Jul 21, 2024
mmmray added a commit that referenced this issue Jul 21, 2024
@mmmray
Fix serverside TLS support of SplitHTTP H1/H2 (#3567)
529f206 
Fix #3566

Also update testsuite so that all tests read and write some data. Opening a connection is not enough to trigger connection errors, because the connection is so lazy.
leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this issue Oct 29, 2024
@mmmray @leninalive
Fix serverside TLS support of SplitHTTP H1/H2 (XTLS#3567)
b04bf0a 
Fix XTLS#3566

Also update testsuite so that all tests read and write some data. Opening a connection is not enough to trigger connection errors, because the connection is so lazy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix serverside TLS support of SplitHTTP H1/H2 mmmray/Xray-core
1 participant
@mmmray