Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

统一 domainStrategy 行为. (sockopt) #2043

Closed
wants to merge 1 commit into from
Closed

统一 domainStrategy 行为. (sockopt) #2043

wants to merge 1 commit into from

Conversation

rui0572
Copy link
Contributor

@rui0572 rui0572 commented May 6, 2023

@rui0572
Copy link
Contributor Author

rui0572 commented May 6, 2023 •
edited
Loading

尚未 merge 的代码在 Action 中也是有编译好的二进制下载的.

也许得有人帮忙测测这堆 Ctrl-C Ctrl-V 出来的东西确实有效.

@yuhan6665 yuhan6665 force-pushed the main branch 2 times, most recently from c73e413 to a4e80f0 Compare June 7, 2023 16:27
@chika0801 chika0801 mentioned this pull request Jun 26, 2023
Closed
@Amin649136411
Copy link

ok

@RPRX
Copy link
Member

RPRX commented Aug 26, 2023

感谢 PR，为了稳一点，domainStrategy 相关修改放到 v1.9

既然行为统一了，麻烦把这三个 PR 合并，domainStrategy 设置都放 sockopt（包括 wg），freedom 为了兼容旧版也可写自己那里

@rui0572
Copy link
Contributor Author

rui0572 commented Nov 4, 2023

抱歉过了很长时间才回复.

domainStrategy 设置都放 sockopt（包括 wg）

XRay 目前的逻辑是

  • sockopt.domainStrategy 控制服务器地址的解析策略，对于 wg 出站来说就是解析 peers.endpoint 的策略
  • settings.domainStrategy 控制的则是真正的解析策略

对于 freedom 来说 sockopt.domainStrategy 猜测只对 settings.redirect 里的域名有效 (?)

所以大概还是维持目前的逻辑比较好吧?

@yuhan6665
Copy link
Member

感谢！先合了 #2720

@yuhan6665 yuhan6665 closed this Nov 12, 2023
@yuhan6665 yuhan6665 mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amin649136411 Amin649136411 Amin649136411 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rui0572 @Amin649136411 @RPRX @yuhan6665