Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS and Dialer Update #341

Merged
merged 7 commits into from Mar 6, 2021
Merged

DNS and Dialer Update #341

merged 7 commits into from Mar 6, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 6, 2021

  • Add: DNS query log
  • Add: Chain proxy with transport layer
  • Add: Domain strategy of system dialer
  • Fix: DoH interrupted after each request

@RPRX RPRX merged commit db32ce6 into XTLS:main Mar 6, 2021
@RPRX
Copy link
Member

RPRX commented Mar 6, 2021

#234

yuhan6665 added a commit to yuhan6665/Xray-core that referenced this pull request Mar 7, 2021
ghost pushed a commit that referenced this pull request Mar 7, 2021
Co-Authored-By: yuhan6665 <1588741+yuhan6665@users.noreply.github.com>
RPRX pushed a commit that referenced this pull request Mar 7, 2021
Co-authored-by: yuhan6665 <1588741+yuhan6665@users.noreply.github.com>
@badO1a5A90
Copy link
Member

badO1a5A90 commented Sep 4, 2021

这个改动中的远程DOH还有一个小问题,举个例子
远程DOH模式下,比如远程DOH服务器地址为1.1.1.1
当1.1.1.1的路由规则的出站是balancer时,由于连接被保持,新的请求不会在balancer中再次选择,除非在IdleConnTimeout指定时间内没有新请求,才会在下一次请求时,重新从balancer选择并建立连接.
虽然在目前的balancer只是 随机规则 下影响似乎不大,但如果balancer有更好的策略时,会有影响.
@hmol233

@hmol233
Copy link
Contributor

hmol233 commented Sep 4, 2021

并不认为这是一个“问题”,而是 HTTP/2 的特性。
这类负载均衡更适合由其他更专业的软件完成(如 CoreDNS)。

@badO1a5A90
Copy link
Member

badO1a5A90 commented Sep 4, 2021

并不是指实际使用中会有问题.
emmm,似乎这个默认数值,如果用户配置了配置文件的 policy中的connIdle值,应该可以由这个策略配置的值覆盖掉, 就符合程序逻辑了,
现在是这样的吗?

PS: @hmol233 你是大H么

@hmol233
Copy link
Contributor

hmol233 commented Sep 5, 2021

是的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants