-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: RPC call causes xray panic problem using wrong account type #3744
Conversation
…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic
|
all |
We have our own log system, please use |
|
ok |
|
应该算吧 rpc调用直接把xray搞挂了 哈哈哈 |
还好,这是调用方调试代码时就能发现的问题
|
我看了下这个是只改了 VMess 的代码,VLESS 的不用改? |
This fix is optional, the main issue is with caller code. |
|
Please delete my commit message
发自我的iPhone
…------------------ Original ------------------
From: RPRX ***@***.***>
Date: Sun,Sep 15,2024 11:52 AM
To: XTLS/Xray-core ***@***.***>
Cc: bob ***@***.***>, Author ***@***.***>
Subject: Re: [XTLS/Xray-core] Fix: RPC call causes xray panic problem usingwrong account type (PR #3744)
This fix is optional, the main issue is with caller code. Guys, please don't drag long review of simple fixes. Move fast and break things!
所以 VLESS 的怎么说
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@yuhan6665 说你可能是想删掉那个邮箱,然而这么久了 Xray 已经被 fork 了 N 份,到处都有备份,删不完的,光是这个 PR 就有 https://github.com/XTLS/Xray-core/commit/8da3d3e78a0da7b0388acceb5ef8892e6d3d4a6f.patch |
…S#3744) * fix:RPC call causes xray panic problem. Problem details: add a VMess protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic * fix:use xray log system return error --------- Co-authored-by: chengtao@snqu.com <chengtao@snqu.com>
…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic