Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: RPC call causes xray panic problem using wrong account type #3744

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

bestwishCT
Copy link
Contributor

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic
@bestwishCT
Copy link
Contributor Author

RPC call causes xray panic problem. Problem details: add a VMess protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic
panic

@RPRX
Copy link
Member

RPRX commented Aug 30, 2024

仅新版的问题还是?

@bestwishCT
Copy link
Contributor Author

仅新版的问题还是?

all

@Fangliding
Copy link
Member

Fangliding commented Aug 30, 2024

We have our own log system, please use errors.New("message")

@RPRX
Copy link
Member

RPRX commented Aug 30, 2024

仅新版的问题还是?

all

那放到 v24.9.30 吧

@bestwishCT
Copy link
Contributor Author

We have our log system, please use errors.New("message")

ok

@RPRX
Copy link
Member

RPRX commented Aug 30, 2024

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

看了描述才发现这甚至不能算是 bug,吓我一跳,真不想弄个 v1.8.25 出来

@bestwishCT
Copy link
Contributor Author

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

看了描述才发现这甚至不能算是 bug,吓我一跳,真不想弄个 v1.8.25 出来

应该算吧 rpc调用直接把xray搞挂了 哈哈哈

@RPRX
Copy link
Member

RPRX commented Aug 30, 2024

…protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

看了描述才发现这甚至不能算是 bug,吓我一跳,真不想弄个 v1.8.25 出来

应该算吧 rpc调用直接把xray搞挂了 哈哈哈

还好,这是调用方调试代码时就能发现的问题

像只有 VLESS 协议的 VLESS-rust 就不会有这种问题 这个的确是画饼了

@RPRX
Copy link
Member

RPRX commented Sep 6, 2024

我看了下这个是只改了 VMess 的代码,VLESS 的不用改?

@yuhan6665 yuhan6665 changed the title fix:RPC call causes xray panic problem. Problem details: add a VMess … Fix: RPC call causes xray panic problem using wrong account type Sep 9, 2024
@yuhan6665
Copy link
Member

This fix is optional, the main issue is with caller code.
Guys, please don't drag long review of simple fixes. Move fast and break things!

@yuhan6665 yuhan6665 merged commit c90affe into XTLS:main Sep 9, 2024
36 checks passed
@RPRX
Copy link
Member

RPRX commented Sep 15, 2024

This fix is optional, the main issue is with caller code. Guys, please don't drag long review of simple fixes. Move fast and break things!

所以 VLESS 的怎么说

@bestwishCT
Copy link
Contributor Author

bestwishCT commented Sep 15, 2024 via email

@RPRX
Copy link
Member

RPRX commented Sep 16, 2024

Please delete my commit message

@yuhan6665 说你可能是想删掉那个邮箱,然而这么久了 Xray 已经被 fork 了 N 份,到处都有备份,删不完的,光是这个 PR 就有 https://github.com/XTLS/Xray-core/commit/8da3d3e78a0da7b0388acceb5ef8892e6d3d4a6f.patch

leninalive pushed a commit to amnezia-vpn/amnezia-xray-core that referenced this pull request Oct 29, 2024
…S#3744)

* fix:RPC call causes xray panic problem. Problem details: add a VMess protocol user in an inbound proxy. If inTag: "VMess-xxx", but the developer carelessly calls the add user method of vless or other protocols, such as xrayCtl.AddVlessUser(user), causing xray panic

* fix:use xray log system return error

---------

Co-authored-by: chengtao@snqu.com <chengtao@snqu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants