Log: show the matching rule tag #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhan6665
reviewed
Sep 13, 2024
app/router/router.go
Outdated
| @@ -80,16 +80,16 @@ func (r *Router) Init(ctx context.Context, config *Config, d dns.Client, ohm out | |||
| } | |||
|
|
|||
| // PickRoute implements routing.Router. | |||
| func (r *Router) PickRoute(ctx routing.Context) (routing.Route, error) { | |||
There was a problem hiding this comment.
Return 3 个有点难看 加到 routing.Route 里？或者直接改成返回 rule?
There was a problem hiding this comment.
看起来是个好主意 已经放到routing.Route里了
|
Looks good to me! |
leninalive
pushed a commit
to amnezia-vpn/amnezia-xray-core
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3311
加一个子命令是不太可能了 但是可以选择在log中输出命中的规则
翻了一下代码之后发现一个似乎没人用文档也没写的
“ruleTag”项 不如用起来现在如果设置了
“ruleTag”在hit中这个rule的时候便会显示这个tag名 用于调试效果如图