-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SplitHTTP server: Add global CORS headers for browser dialer #3830
Conversation
I typically add them with nginx or cloudflare rules and never connect to the core directly. However, I recognize that this should be supported. I think splithttp in particular has already too many response header settings ( Or actually, the headers can be added unconditionally if the path is validated, so no option is needed. I also see you only set them for the GET branch, I think it's better to have those headers in |
I think set it default should be enough, no need to add a new field |
@mmmray @Fangliding What about merging both into |
the reason one would want to disable SSE header is not related to this, so it feels awkward to couple them. I am now convinced that it's best to send them unconditionally. |
I'll remove the config option then. |
I think this will work. Thanks! |
@mmmray 话说 xmux 好像支持不了 browser dialer,因为 chrome 自动控制复用且没提供控制它的 API? |
Yes, I think that's correct. I can't control h2mux behavior or even the HTTP version at all. I guess one could redesign browser dialer so that xray is the one launching and controlling chromium (and then, it can launch many processes or tweak some about:config to force un-muxing), or maybe un-muxing can be done by opening many incognito windows, but it all feels very strange. |
@mmmray 写一下 #3823 (comment) ,这个月就它了 |
I've seen the post, can't promise anything by end of month |
|
Spotted a potential oversight sifting through the browser dialer section of SplitHTTP. If there are complications regarding CORS, this PR should fix them.