Chore: Improved log messaging #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhan6665
reviewed
Nov 25, 2024
proxy/vless/inbound/inbound.go
Outdated
| } | ||
| case "": | ||
| inbound.CanSpliceCopy = 3 | ||
| if account.Flow == vless.XRV && (request.Command == protocol.RequestCommandTCP || isMuxAndNotXUDP(request, first)) { | ||
| return errors.New(account.ID.String() + " is not able to use \"\". Note that the pure TLS proxy has certain TLS in TLS characters.").AtWarning() | ||
| return errors.New("account " + account.ID.String() + " is not able to use the flow \"none\". Note that the pure TLS proxy has certain TLS in TLS characters.").AtWarning() |
There was a problem hiding this comment.
Since there is no such flow as "none". Maybe better to say
..is rejected since the client flow is empty
There was a problem hiding this comment.
Yeah, it makes sense. I will update the wording
|
Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a line that appeared in my logs that is quite ambiguous. Only after reading the source code could I understand what that meant. Fixing that to make the reason for the Warn clearer