Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shouldSniffDomain for (FakeDNS) Sniffer #436

Closed
wants to merge 9 commits into from
Closed

feat: shouldSniffDomain for (FakeDNS) Sniffer #436

wants to merge 9 commits into from

Conversation

rurirei
Copy link
Contributor

@rurirei rurirei commented Mar 24, 2021 •
edited
Loading

to ensure uses FakeDNSSniffer only (not do pendingSniffers to do domain sniff unnecessarily) when if it succeed.

@rurirei rurirei closed this Mar 25, 2021
@rurirei rurirei reopened this Mar 25, 2021
@ghost ghost requested a review from AkinoKaede March 26, 2021 04:34
@RPRX
Copy link
Member

RPRX commented Mar 30, 2021

麻烦 @yuhan6665 看一下

@rurirei
Copy link
Contributor Author

rurirei commented Mar 30, 2021 •
edited
Loading

@.xiaokangwang may designed v2fly/v2ray-core#406 to quickly return result of FakeDNSSniffer only when metadataOnly true.

this is an opinion to ensure not do domain sniffing twice when metadataOnly false, as for v2fly/v2ray-core#697 @.yuhan6665

@rurirei rurirei changed the title fix: FakeDNSSniffer return if succeed fix: FakeDNSSniffer quick return Mar 30, 2021
@rurirei
Copy link
Contributor Author

rurirei commented Mar 31, 2021 •
edited
Loading

i will do a refactor commit. tell me if there is a better implementation.

here keeps for conversation.

EDIT: may ok now.

@rurirei rurirei closed this Mar 31, 2021
@rurirei rurirei reopened this Mar 31, 2021
@rurirei rurirei changed the title fix: FakeDNSSniffer quick return fix: snifferWithMetadata{} update for FakeDNSSniffer Mar 31, 2021
@rurirei rurirei mentioned this pull request Apr 2, 2021
Closed
@rurirei rurirei changed the title fix: snifferWithMetadata{} update for FakeDNSSniffer feat: shouldSniffDomain for (FakeDNS) Sniffer Apr 2, 2021
@rurirei rurirei marked this pull request as draft April 13, 2021 14:44
@rurirei rurirei closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhan6665 yuhan6665 yuhan6665 left review comments

@AkinoKaede AkinoKaede Awaiting requested review from AkinoKaede

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rurirei @RPRX @yuhan6665