Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CLI styler options overrides #249

Merged
merged 6 commits into from
Jan 14, 2020
Merged

Implement CLI styler options overrides #249

merged 6 commits into from
Jan 14, 2020

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Jan 10, 2020 •
edited
Loading

Description:

Implement CLI overrides for styler options.
Changes to documentation will be needed to make note of this.

Fixes #244

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested my changes by running the extension in VS2017
  • I have tested my changes by running the extension in VS2019
  • If changes to the documentation are needed, I have noted this in the description above

grochocki
grochocki requested changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@grochocki grochocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! A couple code review comments. I also still need to do a little manual testing.

XamlStyler.Console/XamlStylerConsole.cs Show resolved Hide resolved
XamlStyler.Console/XamlStylerConsole.cs Show resolved Hide resolved
XamlStyler.Console/XamlStylerConsole.cs Outdated Show resolved Hide resolved
XamlStyler.Console/Options.cs Outdated Show resolved Hide resolved
grochocki
grochocki approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@grochocki grochocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some testing, and everything seems to be working--this is a great addition to the CLI! Thanks again.

@grochocki grochocki merged commit 54a605e into Xavalon:master Jan 14, 2020
@Tyrrrz
Copy link
Contributor Author

Tyrrrz commented Jan 14, 2020

Thanks :)

2coder pushed a commit to 2coder/XamlStyler that referenced this pull request Feb 5, 2020
@Tyrrrz @grochocki @2coder
Implement CLI styler options overrides (Xavalon#249)
fb2f412 
* Implement CLI styler options overrides

* Update with review comments

* Add brackets to ifs

Co-authored-by: Dave Grochocki <grochocki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grochocki grochocki grochocki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XamlStyler.Console should be able to accept options via command line arguments
2 participants
@Tyrrrz @grochocki