Better handle internal VS exceptions relating to .csproj files #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grochocki
approved these changes
Dec 27, 2023
This was referenced Mar 7, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Stop internal VS exceptions causing the extension to break or report errors.
It seems that as of ~17.8, there are possible exceptions getting the ActiveDocument when it is an open
.csprojfile or querying whether it is read-only.This PR adds exception trapping & suppressing for these possible (& now likely) scenarios.
Over many years of working with different file and project types within Visual Studio extensions, I've learned to be very wary of trusting that calls to properties of documents will always be available or returned without throwing an error. I'm surprised this project has gone so long without encountering such an issue before. (Although maybe #278 is an indication that it hasn't.)
These changes have been made in the shared Windows code, but I've only tested in VS2022.
I can't foresee any issues with them affecting the other VS (2019) build, though.
This change is Visual Studio-specific and will not affect the Rider build.
Fixes #448 (issue)
Checklist:
I have tested with VS 17.8.2 and 17.9.0 Preview 1.1 - The two specific issues I have added exception handling for were happening separately on each of the versions.