Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for Rider 2024.2 #499

Merged
merged 4 commits into from
Sep 4, 2024
Merged

adds support for Rider 2024.2 #499

merged 4 commits into from
Sep 4, 2024

Conversation

NicoVermeir
Copy link
Contributor

@NicoVermeir NicoVermeir commented Aug 20, 2024

Description:

Fixes #493, #500

Adds support for Rider 2024.2

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • [ X] My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested my changes by running the extension in VS2017
  • I have tested my changes by running the extension in VS2019
  • I have tested my changes by running the extension in VS2022
  • [ X] I have tested my changes by running the extension in Rider
  • If changes to the documentation are needed, I have noted this in the description above

@ziomek64 ziomek64 mentioned this pull request Aug 22, 2024
@NicoVermeir
Copy link
Contributor Author

@grochocki can you trigger a new build?

@grochocki
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

grochocki
grochocki previously approved these changes Aug 23, 2024
@DavidBChristensen
Copy link

Does Gradle just need to be upgraded (to IntelliJ Platform Gradle Plugin 2.*+), or is it more complicated than that?

https://dev.azure.com/xavalon/XAML%20Styler/_build/results?buildId=553&view=logs&j=35ca6247-b28c-5147-1c3e-8a4bfa1c9008&t=75b3fa51-2e9a-5abc-fa88-7dc94bfb6bcf&l=699

@NicoVermeir
Copy link
Contributor Author

Does Gradle just need to be upgraded (to IntelliJ Platform Gradle Plugin 2.*+), or is it more complicated than that?

https://dev.azure.com/xavalon/XAML%20Styler/_build/results?buildId=553&view=logs&j=35ca6247-b28c-5147-1c3e-8a4bfa1c9008&t=75b3fa51-2e9a-5abc-fa88-7dc94bfb6bcf&l=699

unfortunately it is more complicated than that, more details in #500

@NicoVermeir
Copy link
Contributor Author

@grochocki can you review the PR?

@grochocki grochocki merged commit e37a025 into master Sep 4, 2024
5 checks passed
@grochocki grochocki deleted the feature/rider-2024-2 branch September 4, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rider EAP build
5 participants