Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add log separators for each sample #682

Conversation

ReenigneArcher
Copy link
Contributor

This PR adds expandable divisions for each section when building samples in CI.

image

@thrimbor
Copy link
Member

Hm, could be a little confusing due to how building nxdk is mixed into building the first sample (not your fault), but I still like it.
Commit title doesn't quite follow nxdk's convention though, could you please change it to ci: Add log separators for each sample? (ci prefix and capitalized first letter after the colon)

@ReenigneArcher ReenigneArcher changed the title ci(samples): add log separators for each sample ci: Add log separators for each sample Oct 30, 2024
@ReenigneArcher ReenigneArcher force-pushed the ci/samples/add-log-separators-for-each-sample branch from 43be0a3 to f3143fa Compare October 30, 2024 02:52
@ReenigneArcher
Copy link
Contributor Author

Updated.

@ReenigneArcher ReenigneArcher force-pushed the ci/samples/add-log-separators-for-each-sample branch 2 times, most recently from 022ce20 to 917f195 Compare October 30, 2024 03:45
@ReenigneArcher
Copy link
Contributor Author

could be a little confusing due to how building nxdk is mixed into building the first sample (not your fault)

Pushed a change to address this.

@thrimbor
Copy link
Member

Did you intend to combine the changes into one commit? It's a bit weird now with the title not describing the more important change

@ReenigneArcher
Copy link
Contributor Author

Yes and not sure what you mean, really. IMO, the important change in this PR is dividing the sample build logs.

@thrimbor
Copy link
Member

That's what I mean, dividing the build logs is the significant change, but the commit title is ci: Build nxdk before samples, not even mentioning it.

@ReenigneArcher ReenigneArcher force-pushed the ci/samples/add-log-separators-for-each-sample branch from 917f195 to 2b02491 Compare October 31, 2024 02:02
@ReenigneArcher
Copy link
Contributor Author

Oh... that's what I get for doing this in the middle of the night. Updated it.

Also FYI, you can do "squash and merge" and make the commit messages whatever you want in your repo upon merge.

@thrimbor thrimbor merged commit 91d4e7f into XboxDev:master Oct 31, 2024
6 checks passed
@ReenigneArcher ReenigneArcher deleted the ci/samples/add-log-separators-for-each-sample branch October 31, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants