Feature/m3o dbaas #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est case for added_since
…pi adapter with dummy repos module to test api calls. ignoring [no-any-unimported] for starlette Request
…odules in python executable and mypy config set to pyproject.toml. update mypy ignore in app.py
…. this is needed to set within project scope virtualenv. this allows setting virtualenv and installing poetry packages locally.
…ernal deployment services
… cors middleware on app server
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 0.08%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
* updated Structure of core project * smaller header style * added geolocation and added_since fields. added application service test case for added_since * Format code with black and isort * commented description on complex regex string * added mypy to poetry, updated precommit. refactored and updates fastapi adapter with dummy repos module to test api calls. ignoring [no-any-unimported] for starlette Request * no need of requirements file. updated pre-commit mypy to resolve to modules in python executable and mypy config set to pyproject.toml. update mypy ignore in app.py * updated readme to add poetry.toml; this is not extensively documented. this is needed to set within project scope virtualenv. this allows setting virtualenv and installing poetry packages locally. * Format code with black and isort * shortened command is easier to reproduce, port and build in CI on external deployment services * adding another dockerfile that works as image for cloud run. updating cors middleware on app server * Format code with black and isort * Add a shebang or a 'shell' directive. * error when it errs * Format code with black and isort Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Co-authored-by: Sourcery AI <>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
codecakes
added
enhancement
… bootstrap.py and di_builder. updated logic in m3o repo.
nlinde
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature branch implements m3o database adapter.
A good way to locally test is like
docker run -it --rm -p 8081:8080 -e LOCAL_PORT=8080 -e DOCUMENTATION_API=0.0.0.0:8080 -e M3O_API_TOKEN=$M3O_API_TOKEN -e ENV=testwhere M3O_API_TOKEN is the API token from M3O account.
start.shto run on test or prod level;