Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty enum values from specs #578

Merged
merged 4 commits into from
Jan 19, 2024

Conversation

Raghunath-S-S-J
Copy link
Contributor

Description

This change is to remove empty enum values from the specifications of Accounting, Bankfeeds, Payroll_AU, and Projects.

Release Notes

The empty enum values use a reserved keyword name in PHP which causes errors while utilising the SDK. Issue reported at xero-php-oauth2 #258

Screenshots (if appropriate):

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

PETOSS-382

Copy link

Thanks for raising an issue, a ticket has been created to track your request

@0GH4J
Copy link
Contributor

0GH4J commented Jan 17, 2024

@Raghunath-S-S-J - could you please increment the version in each of the specs with this PR?

@Raghunath-S-S-J
Copy link
Contributor Author

Hi @0GH4J
Increased the major version to avoid potential compatibility issues for users relying on empty values. We're always open to other viewpoints.

@rdemarco-xero
Copy link
Collaborator

Hi @Raghunath-S-S-J , historically we have incremented the patch number for small things like enum changes. If an endpoint gains or loses a param, or there are new endpoints, then we would increment the minor number. The major version almost never changes.

For now, I think it best we just make the version for this PR 2.40.3 for consistency sake. We can then create a task to come up with a more standardized approach.

@rdemarco-xero rdemarco-xero merged commit 5b047f4 into XeroAPI:master Jan 19, 2024
@Raghunath-S-S-J
Copy link
Contributor Author

Hi @rdemarco-xero, Thanks for clarifying. I have reverted the version to 2.40.3 as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants