Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xero_accounting.yaml #595

Conversation

ronnel-santiago-xero
Copy link
Contributor

@ronnel-santiago-xero ronnel-santiago-xero commented Jun 13, 2024

Description

Adds the page size query parameter to "get all" endpoints for bank transactions, contacts, credit notes, invoices, manual journals, payments and purchase orders. APIB-5518.

Release Notes

Screenshots (if appropriate):

We are to add the pagesize query parameter on api-explorer.
image

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link

PETOSS-434

Copy link

Thanks for raising an issue, a ticket has been created to track your request

pageSize:
in: query
name: pageSize
x-snake: page_size
Copy link
Contributor Author

@ronnel-santiago-xero ronnel-santiago-xero Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This x-snake, what is the relevance of it?
Or I simply omit?

Note that the purpose of this PR is to add the pagesize query parameter to api-explorer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed that x-snake.

@ronnel-santiago-xero ronnel-santiago-xero force-pushed the apib-5518_pagesizeQueryParam-xero branch from 04cfa3a to 5a8d8e9 Compare June 20, 2024 01:01
[APIB-5518] Adds the page size query parameter to "get all" endpoints for bank transactions, contacts, credit notes, invoices, manual journals, payments and purchase orders.
@ronnel-santiago-xero ronnel-santiago-xero force-pushed the apib-5518_pagesizeQueryParam-xero branch from 5a8d8e9 to 5e4c593 Compare June 26, 2024 01:08
@sangeet-joy-tw sangeet-joy-tw merged commit d773c36 into XeroAPI:master Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants