This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
filesystem: bug fix & code refactor #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shengofsun
commented
Aug 6, 2018
shengofsun
commented
- fix thread safety problem of strerror
- remove source code for windows
shengofsun
requested review from
qinzuoyan,
54chen,
neverchanje and
acelyc111
and removed request for
54chen
1. fix thread safety problem of strerror 2. remove code for windows
neverchanje
reviewed
Aug 7, 2018
src/core/core/utils.cpp
Outdated
| !defined _GNU_SOURCE) | ||
| int result = strerror_r(err, errno_buffer, 256); | ||
| if (result != 0) { | ||
| printf("call strerror_r faild, old_err(%d), new_err(%d), ret(%d)\n", err, errno, result); |
There was a problem hiding this comment.
目前是在避免采用dlog系列。dlog系列实在是太毒瘤了，引用了就要依赖整个runtime
There was a problem hiding this comment.
那也应该用 fprintf(stderr, ) 啊，而且正常的基础库都会依赖一个日志库的，你也不能因为避免打日志就用 printf
|
另外 butil 了解一下： |
|
safe_strerror是我自己写的…… |
|
butin的safe_strerror内存拷贝次数有点多啊。不过虽然也不要紧，因为打印这个的时候都是出问题了的时候。 |
|
butil 拷贝再多也只是 256 bytes 的拷贝，我推荐这个主要还是因为它们从 chromium 拷过来的，注释写的比较充分，理论上也比较 stable。 |
qinzuoyan
approved these changes
Aug 8, 2018
neverchanje
approved these changes
Aug 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.